Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

LH-253: Added callId for transportclose and producerclose events #12

Merged
sergiu merged 2 commits from LH-253-mediasoup-handle-callid-undefined into master 2022-10-18 07:53:33 +00:00
Conversation 0 Commits 2 Files Changed 1 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app.js
View File

@ -109,7 +109,7 @@ const mediaCodecs = [
const closeCall = (callId) => {
try {
if (videoCalls[callId]) {
if (callId && videoCalls[callId]) {
videoCalls[callId].producer?.close();
videoCalls[callId].consumer?.close();
videoCalls[callId]?.consumerTransport?.close();
@ -299,14 +299,14 @@ peers.on('connection', async socket => {
videoCalls[callId].consumer.on('transportclose', () => {
const callId = socketDetails[socket.id];
console.log('transport close from consumer', callId);
closeCall();
closeCall(callId);
cristi commented 2022-10-18 07:48:53 +00:00
Review
Copy Link

We should test callId to be a valid value before using it in closeCall.

We should test `callId` to be a valid value before using it in `closeCall`.
});
// https://mediasoup.org/documentation/v3/mediasoup/api/#consumer-on-producerclose
videoCalls[callId].consumer.on('producerclose', () => {
const callId = socketDetails[socket.id];
console.log('producer of consumer closed', callId);
closeCall();
closeCall(callId);
});
// From the consumer extract the following params to send back to the Client