Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

LH-253: Added callId for transportclose and producerclose events #12

Merged
sergiu merged 2 commits from LH-253-mediasoup-handle-callid-undefined into master 2022-10-18 07:53:33 +00:00
Conversation 0 Commits 2 Files Changed 1 +3 -3
sergiu commented 2022-10-17 23:06:42 +00:00
Member
Copy Link
No description provided.
sergiu added 1 commit 2022-10-17 23:06:43 +00:00
sergiu requested review from cristi 2022-10-17 23:06:46 +00:00
cristi approved these changes 2022-10-18 07:50:34 +00:00
app.js
@ -300,3 +300,3 @@
const callId = socketDetails[socket.id];
console.log('transport close from consumer', callId);
closeCall();
closeCall(callId);
cristi commented 2022-10-18 07:48:53 +00:00
Owner
Copy Link

We should test callId to be a valid value before using it in closeCall.

We should test `callId` to be a valid value before using it in `closeCall`.
sergiu added 1 commit 2022-10-18 07:51:27 +00:00
sergiu merged commit be5f97762a into master 2022-10-18 07:53:33 +00:00
sergiu deleted branch LH-253-mediasoup-handle-callid-undefined 2022-10-18 07:53:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
cristi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Safemobile/mediasoup#12
No description provided.
Delete Branch "LH-253-mediasoup-handle-callid-undefined"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?