sergiu
/
linx-sdk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

LINXD-2559-sdk-part-1-auth-connect-events: Add event handler for client #1

Merged
sergiu merged 1 commits from LINXD-2559-sdk-part-1-auth-connect-events into main 2023-12-06 11:09:03 +00:00
Conversation 0 Commits 1 Files Changed 5 +44 -6
sergiu commented 2023-12-02 13:09:46 +00:00
Owner
Copy Link
No description provided.
sergiu added 1 commit 2023-12-02 13:09:46 +00:00
sergiu requested review from cristi 2023-12-02 13:09:51 +00:00
sergiu reviewed 2023-12-02 13:16:17 +00:00
src/linx-sdk-module/index.ts
@ -33,0 +38,4 @@
CONNECT = "connect",
}
return USER_EVENTS;
}
sergiu commented 2023-12-02 13:16:17 +00:00
Author
Owner
Copy Link

I chose to have two types of models:

  1. The first one to use inside the SDK, is to have all the events in an enum.

  2. The 2nd is in the SDK module and is accessible to the client through linxSdk.models().<event_name>.

I chose this approach because we offer the client a predefined list of events we interface with, but not all the events with which the SDK works. Another reason is security.

I chose to have two types of models: 1. The first one to use inside the SDK, is to have all the events in an enum. 1. The 2nd is in the SDK module and is accessible to the client through **linxSdk.models().<event_name>**. --- I chose this approach because we offer the client a predefined list of events we interface with, but not all the events with which the SDK works. Another reason is security.
cristi approved these changes 2023-12-06 10:33:44 +00:00
sergiu merged commit 5c5b5dded6 into main 2023-12-06 11:09:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
cristi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sergiu/linx-sdk#1
No description provided.
Delete Branch "LINXD-2559-sdk-part-1-auth-connect-events"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?