SD-230
develop
@ -574,0 +583,4 @@
else {
NetworkRequest request = new NetworkRequest.Builder()
.addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET).build();
connectivityManager.registerNetworkCallback(request, networkCallback);
This is done on both branches, should be outside of if.
if
On first branch it has one parameter and in the second one has two.
@ -576,0 +609,4 @@
uiHandler.post(() -> {
Log.v(TAG, "myService: " + (myService != null));
if (myService != null) {
myService.stopTCPConnection();
Is this related to tcp.Stop() above? Is it independent? Why?
tcp.Stop()
@ -576,0 +614,4 @@
getApplicationContext().bindService(new Intent(context, TCPService.class), serviceConnection, Context.BIND_AUTO_CREATE);
if (getRadioActivity() != null)
getRadioActivity().onCreate(getRadioActivity().savedInstanceState);
Why is here savedInstanceState and getSavedInstanceState on the others?
savedInstanceState
getSavedInstanceState
Because savedInstanceState is the name of the variable and we didn't have a getter. Now I've created one and I'm using it.
ok from my side for now
8b89319d09
No due date set.
No dependencies set.
Deleting a branch is permanent. It CANNOT be undone. Continue?
adriana
laurentiu.constantin
cristi
@ -574,0 +583,4 @@else {NetworkRequest request = new NetworkRequest.Builder().addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET).build();connectivityManager.registerNetworkCallback(request, networkCallback);This is done on both branches, should be outside of
if.On first branch it has one parameter and in the second one has two.
@ -576,0 +609,4 @@uiHandler.post(() -> {Log.v(TAG, "myService: " + (myService != null));if (myService != null) {myService.stopTCPConnection();Is this related to
tcp.Stop()above? Is it independent? Why?@ -576,0 +614,4 @@getApplicationContext().bindService(new Intent(context, TCPService.class), serviceConnection, Context.BIND_AUTO_CREATE);if (getRadioActivity() != null)getRadioActivity().onCreate(getRadioActivity().savedInstanceState);Why is here
savedInstanceStateandgetSavedInstanceStateon the others?Because savedInstanceState is the name of the variable and we didn't have a getter. Now I've created one and I'm using it.
ok from my side for now
8b89319d09into develop 1 year agoReviewers
8b89319d09.