handle network swap #32

Merged
CiufudeanDani merged 2 commits from SD-230 into develop 1 year ago
Collaborator
There is no content yet.
CiufudeanDani added 1 commit 1 year ago
CiufudeanDani requested review from cristi 1 year ago
CiufudeanDani requested review from adriana 1 year ago
CiufudeanDani requested review from laurentiu.constantin 1 year ago
cristi requested changes 1 year ago
@ -574,0 +583,4 @@
else {
NetworkRequest request = new NetworkRequest.Builder()
.addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET).build();
connectivityManager.registerNetworkCallback(request, networkCallback);
cristi commented 1 year ago
Owner

This is done on both branches, should be outside of if.

This is done on both branches, should be outside of `if`.
Poster
Collaborator

On first branch it has one parameter and in the second one has two.

On first branch it has one parameter and in the second one has two.
cristi marked this conversation as resolved
@ -576,0 +609,4 @@
uiHandler.post(() -> {
Log.v(TAG, "myService: " + (myService != null));
if (myService != null) {
myService.stopTCPConnection();
cristi commented 1 year ago
Owner

Is this related to tcp.Stop() above? Is it independent? Why?

Is this related to `tcp.Stop()` above? Is it independent? Why?
@ -576,0 +614,4 @@
getApplicationContext().bindService(new Intent(context, TCPService.class), serviceConnection, Context.BIND_AUTO_CREATE);
if (getRadioActivity() != null)
getRadioActivity().onCreate(getRadioActivity().savedInstanceState);
cristi commented 1 year ago
Owner

Why is here savedInstanceState and getSavedInstanceState on the others?

Why is here `savedInstanceState` and `getSavedInstanceState` on the others?
Poster
Collaborator

Because savedInstanceState is the name of the variable and we didn't have a getter. Now I've created one and I'm using it.

Because savedInstanceState is the name of the variable and we didn't have a getter. Now I've created one and I'm using it.
cristi marked this conversation as resolved
CiufudeanDani added 1 commit 1 year ago
cristi approved these changes 1 year ago
cristi left a comment
Owner

ok from my side for now

ok from my side for now
CiufudeanDani merged commit 8b89319d09 into develop 1 year ago

Reviewers

adriana was requested for review 1 year ago
laurentiu.constantin was requested for review 1 year ago
cristi approved these changes 1 year ago
The pull request has been merged as 8b89319d09.
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Safemobile/safedispatch-mobile#32
Loading…
There is no content yet.