Safemobile/safedispatch-mobile
20
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

handle network swap #32

Merged
CiufudeanDani merged 2 commits from SD-230 into develop 2022-05-03 08:27:34 +00:00
Conversation 0 Commits 2 Files Changed 3 +271 -442
CiufudeanDani commented 2022-05-02 13:20:34 +00:00
Member
Copy Link
No description provided.
CiufudeanDani added 1 commit 2022-05-02 13:20:34 +00:00
CiufudeanDani requested review from cristi 2022-05-02 13:20:51 +00:00
CiufudeanDani requested review from adriana 2022-05-02 13:20:51 +00:00
CiufudeanDani requested review from laurentiu.constantin 2022-05-02 13:20:51 +00:00
cristi requested changes 2022-05-02 15:16:14 +00:00
safeDispatch/src/main/java/com/safemobile/safedispatch/TabLayoutActivity.java
@ -574,0 +583,4 @@
else {
NetworkRequest request = new NetworkRequest.Builder()
.addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET).build();
connectivityManager.registerNetworkCallback(request, networkCallback);
cristi commented 2022-05-02 14:37:50 +00:00
Owner
Copy Link

This is done on both branches, should be outside of if.

This is done on both branches, should be outside of `if`.
CiufudeanDani commented 2022-05-03 06:53:31 +00:00
Author
Member
Copy Link

On first branch it has one parameter and in the second one has two.

On first branch it has one parameter and in the second one has two.
cristi marked this conversation as resolved
safeDispatch/src/main/java/com/safemobile/safedispatch/TabLayoutActivity.java
@ -576,0 +609,4 @@
uiHandler.post(() -> {
Log.v(TAG, "myService: " + (myService != null));
if (myService != null) {
myService.stopTCPConnection();
cristi commented 2022-05-02 15:16:11 +00:00
Owner
Copy Link

Is this related to tcp.Stop() above? Is it independent? Why?

Is this related to `tcp.Stop()` above? Is it independent? Why?
safeDispatch/src/main/java/com/safemobile/safedispatch/TabLayoutActivity.java
@ -576,0 +614,4 @@
getApplicationContext().bindService(new Intent(context, TCPService.class), serviceConnection, Context.BIND_AUTO_CREATE);
if (getRadioActivity() != null)
getRadioActivity().onCreate(getRadioActivity().savedInstanceState);
cristi commented 2022-05-02 15:11:27 +00:00
Owner
Copy Link

Why is here savedInstanceState and getSavedInstanceState on the others?

Why is here `savedInstanceState` and `getSavedInstanceState` on the others?
CiufudeanDani commented 2022-05-03 07:46:43 +00:00
Author
Member
Copy Link

Because savedInstanceState is the name of the variable and we didn't have a getter. Now I've created one and I'm using it.

Because savedInstanceState is the name of the variable and we didn't have a getter. Now I've created one and I'm using it.
cristi marked this conversation as resolved
CiufudeanDani added 1 commit 2022-05-03 07:44:53 +00:00
cristi approved these changes 2022-05-03 08:10:36 +00:00
cristi left a comment
Owner
Copy Link

ok from my side for now

ok from my side for now
CiufudeanDani merged commit 8b89319d09 into develop 2022-05-03 08:27:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
adriana
laurentiu.constantin
cristi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Safemobile/safedispatch-mobile#32
No description provided.
Delete Branch "SD-230"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?