Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

LINXD-2842-log-protocol-change #36

Merged
sergiu merged 3 commits from LINXD-2842-log-protocol-change into develop 2025-03-05 21:40:25 +00:00
Conversation 2 Commits 3 Files Changed 5 +1163 -55
sergiu commented 2025-03-04 15:02:35 +00:00
Member
Copy Link
No description provided.
sergiu added 2 commits 2025-03-04 15:02:36 +00:00
sergiu requested review from cristi 2025-03-04 15:02:41 +00:00
sergiu commented 2025-03-04 15:04:03 +00:00
Author
Member
Copy Link

This handler will send protocol change events to clients so they can close the call without waiting for a timeout.

This handler will send protocol change events to clients so they can close the call without waiting for a timeout.
cristi approved these changes 2025-03-05 08:37:20 +00:00
app.js Outdated
@ -565,1 +569,4 @@
transport.on('iceselectedtuplechange', (selectedTuple) => {
const { protocol } = selectedTuple;
const switchedTo = protocol === 'udp' ? 'tcp' : 'udp';
cristi commented 2025-03-05 08:36:43 +00:00
Owner
Copy Link

This seems redundant. Suggestion: we could remove it altogether.

This seems redundant. Suggestion: we could remove it altogether.
sergiu marked this conversation as resolved
app.js Outdated
@ -566,0 +573,4 @@
if (initialConnection !== protocol) {
console.warn(`⚠️ ${protocol.toUpperCase()} blocked! Switching to ${switchedTo.toUpperCase()} for callId: ${callId}`);
initialConnection = protocol;
cristi commented 2025-03-05 08:36:04 +00:00
Owner
Copy Link

suggestion initialConnection --> currentConnectionType

suggestion `initialConnection` --> `currentConnectionType`
sergiu marked this conversation as resolved
sergiu added 1 commit 2025-03-05 21:38:15 +00:00
sergiu merged commit dd5af12c7c into develop 2025-03-05 21:40:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
cristi
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Bogdan Ciprian Ciprian.Ionescu CiufudeanDani ClaudiuS DWK GabrielP Tibi adi adriana andrei.nicolae bmamihai cristi george jenkins laurentiu.constantin sergiu walkervandixhorn
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Safemobile/mediasoup#36
No description provided.
Delete Branch "LINXD-2842-log-protocol-change"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?