Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

WIP: router-close-connections #2

Closed
sergiu wants to merge 13 commits from router-close-connections into master
pull from: router-close-connections
merge into: Safemobile:master
Conversation 0 Commits 13 Files Changed 3 +99 -79
sergiu commented 2022-09-03 17:08:25 +00:00
Member
Copy Link
No description provided.
sergiu added 5 commits 2022-09-03 17:08:25 +00:00
sergiu requested review from cristi 2022-09-03 17:09:03 +00:00
sergiu changed title from router-close-connections to WIP: router-close-connections 2022-09-03 17:18:47 +00:00
cristi requested changes 2022-09-04 13:47:33 +00:00
cristi left a comment
Owner
Copy Link

We need to discuss the next steps, see comment for what clarifications are needed.

We need to discuss the next steps, see comment for what clarifications are needed.
app.js
@ -170,0 +177,4 @@
callback({
id: producer.id
})
} catch (error) {
cristi commented 2022-09-04 13:40:38 +00:00
Owner
Copy Link

Isn't the producer a global variable?

What should the client do with the producer id? Looks below that is sent back to server, why?

Isn't the `producer` a global variable? What should the client do with the producer id? Looks below that is sent back to server, why?
sergiu added 1 commit 2022-09-05 11:32:04 +00:00
sergiu added 1 commit 2022-09-05 14:40:01 +00:00
sergiu added 1 commit 2022-09-05 14:41:43 +00:00
sergiu added 1 commit 2022-09-05 14:49:51 +00:00
sergiu added 1 commit 2022-09-05 14:51:01 +00:00
sergiu added 1 commit 2022-09-05 15:08:02 +00:00
sergiu added 1 commit 2022-09-05 15:11:43 +00:00
sergiu added 1 commit 2022-09-05 15:24:17 +00:00
sergiu closed this pull request 2022-09-25 17:24:34 +00:00
sergiu deleted branch router-close-connections 2022-09-25 17:24:41 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
cristi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Safemobile/mediasoup#2
No description provided.
Delete Branch "router-close-connections"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?