fix

Reviewed-on: #12

.env

@@ -1,3 +1,7 @@
 PORT=3000
 IP=0.0.0.0 #	Listening IPv4 or IPv6.
 ANNOUNCED_IP=185.8.154.190 # Announced IPv4 or IPv6 (useful when running mediasoup behind NAT with private IP).
+RTC_MIN_PORT=2000
+RTC_MAX_PORT=2020
+SERVER_CERT="./server/ssl/cert.pem"
+SERVER_KEY="./server/ssl/key.pem"

app.js

@@ -5,12 +5,7 @@ const app = express();
 const Server = require('socket.io');
 const path = require('node:path');
 const fs = require('node:fs');
-let https = require('https');
-try {
-  https = require('node:https');
-} catch (err) {
-  console.log('https support is disabled!');
-}
+const https = require('https');
 const mediasoup = require('mediasoup');
 
 let worker
@@ -59,16 +54,17 @@ const io = new Server(httpsServer, {
 // const io = new Server(server, { origins: '*:*', allowEIO3: true });
 
 httpsServer.listen(process.env.PORT, () => {
-  console.log('Video server listening on port:', process.env.PORT)
-})
-
-const peers = io.of('/')
+  console.log('Video server listening on port:', process.env.PORT);
+});
 
+const peers = io.of('/');
+console.log('process.env.RTC_MIN_PORT', process.env.RTC_MIN_PORT);
+console.log('process.env.RTC_MAX_PORT', process.env.RTC_MAX_PORT, process.env.RTC_MAX_PORT.length);
 const createWorker = async () => {
   try {
     worker = await mediasoup.createWorker({
-      rtcMinPort: 2000,
-      rtcMaxPort: 2020,
+      rtcMinPort: process.env.RTC_MIN_PORT,
+      rtcMaxPort: process.env.RTC_MAX_PORT,
     })
     console.log(`[createWorker] worker pid ${worker.pid}`);
   
@@ -84,7 +80,7 @@ const createWorker = async () => {
 }
 
 // We create a Worker as soon as our application starts
-worker = createWorker()
+worker = createWorker();
 
 // This is an Array of RtpCapabilities
 // https://mediasoup.org/documentation/v3/mediasoup/rtp-parameters-and-capabilities/#RtpCodecCapability
@@ -105,17 +101,19 @@ const mediaCodecs = [
       'x-google-start-bitrate': 1000,
     },
   },
-]
+];
 
 const closeCall = (callId) => {
   try {
-    if (videoCalls[callId]) {
+    if (callId && videoCalls[callId]) {
       videoCalls[callId].producer?.close();
       videoCalls[callId].consumer?.close();
-      videoCalls[callId]?.consumerTransport.close();
-      videoCalls[callId]?.producerTransport.close();
-      videoCalls[callId].router.close();
+      videoCalls[callId]?.consumerTransport?.close();
+      videoCalls[callId]?.producerTransport?.close();
+      videoCalls[callId]?.router?.close();
       delete videoCalls[callId];
+    } else {
+      console.log(`The call with id ${callId} has already been deleted`);
     }
   } catch (error) {
     console.log(`ERROR | closeCall | callid ${callId} | ${error.message}`);
@@ -146,8 +144,10 @@ peers.on('connection', async socket => {
 
   // It is triggered when the peer is disconnected
   socket.on('disconnect', () => {
-    console.log('peer disconnected | socket.id', socket.id);
+    const callId = socketDetails[socket.id];
+    console.log(`disconnect | socket ${socket.id} | callId ${callId}`);
     delete socketDetails[socket.id];
+    closeCall(callId);
   });
 
   /*
@@ -186,13 +186,21 @@ peers.on('connection', async socket => {
     try {
       const callId = socketDetails[socket.id];
       console.log(`[createWebRtcTransport] sender ${sender} | callId ${callId}`);
-      if (sender && !videoCalls[callId].producerTransport) {
-        videoCalls[callId].producerTransport = await createWebRtcTransportLayer(callId, callback)
-      } else if (!sender && !videoCalls[callId].consumerTransport) {
-        videoCalls[callId].consumerTransport = await createWebRtcTransportLayer(callId, callback)
+      if (sender) {
+        if (!videoCalls[callId].producerTransport) {
+          videoCalls[callId].producerTransport = await createWebRtcTransportLayer(callId, callback);
+        } else {
+          console.log(`producerTransport has already been defined | callId ${callId}`);
+        }
+      } else if (!sender) {
+        if (!videoCalls[callId].consumerTransport) {
+          videoCalls[callId].consumerTransport = await createWebRtcTransportLayer(callId, callback);
+        } else {
+          console.log(`consumerTransport has already been defined | callId ${callId}`);
+        }
       }
     } catch (error) {
-      console.log(`ERROR | createWebRtcTransport | callId ${callId} | sender ${sender} | ${error.message}`);
+      console.log(`ERROR | createWebRtcTransport | callId ${socketDetails[socket.id]} | sender ${sender} | ${error.message}`);
     }
   });
 
@@ -203,7 +211,9 @@ peers.on('connection', async socket => {
   socket.on('transport-connect', async ({ dtlsParameters }) => {
     try {
       const callId = socketDetails[socket.id];
-      console.log(`[transport-connect] socket.id ${socket.id} | callId ${callId}`)
+      if (typeof dtlsParameters === 'string') dtlsParameters = JSON.parse(dtlsParameters);
+
+      console.log(`[transport-connect] socket.id ${socket.id} | callId ${callId}`);
       await videoCalls[callId].producerTransport.connect({ dtlsParameters });
     } catch (error) {
       console.log(`ERROR | transport-connect | callId ${socketDetails[socket.id]} | ${error.message}`);
@@ -215,9 +225,11 @@ peers.on('connection', async socket => {
     - For the router with the id callId, we make produce on producerTransport
     - Create the handler on producer at the 'transportclose' event
   */
-  socket.on('transport-produce', async ({ kind, rtpParameters, appData }) => {
+  socket.on('transport-produce', async ({ kind, rtpParameters, appData }, callback) => {
     try {
       const callId = socketDetails[socket.id];
+      if (typeof rtpParameters === 'string') rtpParameters = JSON.parse(rtpParameters);
+
       console.log('[transport-produce] | socket.id', socket.id, '| callId', callId);
       videoCalls[callId].producer = await videoCalls[callId].producerTransport.produce({
         kind,
@@ -230,6 +242,11 @@ peers.on('connection', async socket => {
         console.log('transport for this producer closed', callId)
         closeCall(callId);
       });
+
+      // Send back to the client the Producer's id
+      // callback({
+      //   id: videoCalls[callId].producer.id
+      // });
     } catch (error) {
       console.log(`ERROR | transport-produce | callId ${socketDetails[socket.id]} | ${error.message}`);
     }
@@ -245,7 +262,7 @@ peers.on('connection', async socket => {
       console.log(`[transport-recv-connect] socket.id ${socket.id} | callId ${callId}`);
       await videoCalls[callId].consumerTransport.connect({ dtlsParameters });
     } catch (error) {
-      console.log(`ERROR | transport-recv-connect | callId ${socketDetails[socket.id]} | ERROR`);
+      console.log(`ERROR | transport-recv-connect | callId ${socketDetails[socket.id]} | ${error.message}`);
     }
   })
 
@@ -278,14 +295,14 @@ peers.on('connection', async socket => {
         videoCalls[callId].consumer.on('transportclose', () => {
           const callId = socketDetails[socket.id];
           console.log('transport close from consumer', callId);
-          closeCall();
+          closeCall(callId);
         });
 
         // https://mediasoup.org/documentation/v3/mediasoup/api/#consumer-on-producerclose
         videoCalls[callId].consumer.on('producerclose', () => {
           const callId = socketDetails[socket.id];
           console.log('producer of consumer closed', callId);
-          closeCall();
+          closeCall(callId);
         });
 
         // From the consumer extract the following params to send back to the Client
@@ -302,7 +319,7 @@ peers.on('connection', async socket => {
         console.log(`[canConsume] Can't consume | callId ${callId}`);
       }
     } catch (error) {
-      console.log(`ERROR | consume | callId ${callId} | ${error.message}`)
+      console.log(`ERROR | consume | callId ${socketDetails[socket.id]} | ${error.message}`)
       callback({ params: { error } });
     }
   });
@@ -376,7 +393,7 @@ const createWebRtcTransportLayer = async (callId, callback) => {
     return transport;
 
   } catch (error) {
-    console.log(`ERROR | createWebRtcTransportLayer | callId ${callId} | ${error.message}`);
+    console.log(`ERROR | createWebRtcTransportLayer | callId ${socketDetails[socket.id]} | ${error.message}`);
     callback({ params: { error } });
   }
 }