Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

LINXD-2197: Added comments; Catch errors; Fix package.json start:run script #8

Merged
sergiu merged 4 commits from LINXD-2197-refactor-improving-mediasoup-web-socket-component into master 2022-09-27 10:00:25 +00:00
Conversation 0 Commits 4 Files Changed 5 +18 -6
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b0fad5f1db - Show all commits

24
app.js
View File

@ -116,6 +116,8 @@ const closeCall = (callId) => {
videoCalls[callId]?.producerTransport.close(); videoCalls[callId]?.producerTransport.close();
videoCalls[callId].router.close(); videoCalls[callId].router.close();
delete videoCalls[callId]; delete videoCalls[callId];
} else {
console.log(`The call with id ${callId} has already been deleted`);
cristi commented 2022-09-27 07:46:45 +00:00
Outdated
Review
Copy Link

It could be useful to have a message like Call id ${callId} already closed

It could be useful to have a message like _Call id ${callId} already closed_
} }
} catch (error) { } catch (error) {
console.log(`ERROR | closeCall | callid ${callId} | ${error.message}`); console.log(`ERROR | closeCall | callid ${callId} | ${error.message}`);
@ -146,8 +148,10 @@ peers.on('connection', async socket => {
// It is triggered when the peer is disconnected // It is triggered when the peer is disconnected
cristi commented 2022-09-27 07:49:20 +00:00
Review
Copy Link

We should also call closeCall here to clean up on disconnect.

We should also call `closeCall` here to clean up on disconnect.
socket.on('disconnect', () => { socket.on('disconnect', () => {
console.log('peer disconnected | socket.id', socket.id); const callId = socketDetails[socket.id];
console.log(`disconnect | socket ${socket.id} | callId ${callId}`);
delete socketDetails[socket.id]; delete socketDetails[socket.id];
closeCall(callId);
}); });
/* /*
@ -186,10 +190,18 @@ peers.on('connection', async socket => {
try { try {
const callId = socketDetails[socket.id]; const callId = socketDetails[socket.id];
cristi commented 2022-09-27 07:38:35 +00:00
Outdated
Review
Copy Link

It could be useful to see a message when the transport is already present.

Producer transport already present. Ignoring. callId=... assetId=...

It could be useful to see a message when the transport is already present. _Producer transport already present. Ignoring. callId=... assetId=..._
console.log(`[createWebRtcTransport] sender ${sender} | callId ${callId}`); console.log(`[createWebRtcTransport] sender ${sender} | callId ${callId}`);
if (sender && !videoCalls[callId].producerTransport) { if (sender) {
videoCalls[callId].producerTransport = await createWebRtcTransportLayer(callId, callback) if (!videoCalls[callId].producerTransport) {
} else if (!sender && !videoCalls[callId].consumerTransport) { videoCalls[callId].producerTransport = await createWebRtcTransportLayer(callId, callback);
videoCalls[callId].consumerTransport = await createWebRtcTransportLayer(callId, callback) } else {
console.log(`producerTransport has already been defined | callId ${callId}`);
}
} else if (!sender) {
if (!videoCalls[callId].consumerTransport) {
videoCalls[callId].consumerTransport = await createWebRtcTransportLayer(callId, callback);
} else {
console.log(`consumerTransport has already been defined | callId ${callId}`);
}
} }
} catch (error) { } catch (error) {
console.log(`ERROR | createWebRtcTransport | callId ${callId} | sender ${sender} | ${error.message}`); console.log(`ERROR | createWebRtcTransport | callId ${callId} | sender ${sender} | ${error.message}`);
@ -245,7 +257,7 @@ peers.on('connection', async socket => {
console.log(`[transport-recv-connect] socket.id ${socket.id} | callId ${callId}`); console.log(`[transport-recv-connect] socket.id ${socket.id} | callId ${callId}`);
await videoCalls[callId].consumerTransport.connect({ dtlsParameters }); await videoCalls[callId].consumerTransport.connect({ dtlsParameters });
} catch (error) { } catch (error) {
console.log(`ERROR | transport-recv-connect | callId ${socketDetails[socket.id]} | ERROR`); console.log(`ERROR | transport-recv-connect | callId ${socketDetails[socket.id]} | ${error.message}`);
} }
}) })