Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

comsume-undefined #22

Merged
sergiu merged 9 commits from comsume-undefined into develop 2023-01-12 13:31:47 +00:00
Conversation 0 Commits 9 Files Changed 1 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit df5b3eab90 - Show all commits

6
app.js
View File

@ -449,10 +449,12 @@ peers.on('connection', async socket => {
console.log(`[consumer-resume] callId ${callId}`) console.log(`[consumer-resume] callId ${callId}`)
if (isInitiator(callId, socket.id)) { if (isInitiator(callId, socket.id)) {
console.log('🟩');
cristi commented 2023-01-12 10:50:44 +00:00
Outdated
Review
Copy Link

Check for videoCalls[callId].initiatorConsumerVideo is redundant.

Check for `videoCalls[callId].initiatorConsumerVideo` is redundant.
console.log(`[consumer-resume] isInitiator true`); console.log(`[consumer-resume] isInitiator true`);
await videoCalls[callId].initiatorConsumerVideo.resume(); (videoCalls[callId].initiatorConsumerAudio) && await videoCalls[callId].initiatorConsumerVideo.resume();
await videoCalls[callId].initiatorConsumerAudio.resume(); (videoCalls[callId].initiatorConsumerAudio) && await videoCalls[callId].initiatorConsumerAudio.resume();
} else { } else {
console.log('🟥');
console.log(`[consumer-resume] isInitiator false`); console.log(`[consumer-resume] isInitiator false`);
(videoCalls[callId].receiverConsumerVideo) && await videoCalls[callId].receiverConsumerVideo.resume(); (videoCalls[callId].receiverConsumerVideo) && await videoCalls[callId].receiverConsumerVideo.resume();
(videoCalls[callId].receiverConsumerVideo) && await videoCalls[callId].receiverConsumerAudio.resume(); (videoCalls[callId].receiverConsumerVideo) && await videoCalls[callId].receiverConsumerAudio.resume();