Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

comsume-undefined #22

Merged
sergiu merged 9 commits from comsume-undefined into develop 2023-01-12 13:31:47 +00:00
Conversation 0 Commits 9 Files Changed 1 +7 -12
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d8405eccc7 - Show all commits

19
app.js
View File

@ -441,23 +441,18 @@ peers.on('connection', async socket => {
/*
- Event sent by the consumer after consuming to resume the pause
- When consuming on consumerTransport, it is initially done with paused: true, here we will resume
- When consuming on consumerTransport, it is initially done with paused: true, here we will resume
- For the initiator we resume the initiatorConsumerAUDIO/VIDEO and for receiver the receiverConsumerAUDIO/VIDEO
*/
socket.on('consumer-resume', async () => {
socket.on('consumer-resume',() => {
try {
const callId = socketDetails[socket.id];
console.log(`[consumer-resume] callId ${callId}`)
if (isInitiator(callId, socket.id)) {
console.log('🟩');
console.log(`[consumer-resume] isInitiator true`);
await videoCalls[callId]?.initiatorConsumerVideo?.resume();
await videoCalls[callId]?.initiatorConsumerAudio?.resume();
initiatorConsumerVideo && videoCalls[callId].initiatorConsumerVideo?.resume();
initiatorConsumerAudio && videoCalls[callId].initiatorConsumerAudio?.resume();
cristi commented 2023-01-12 10:50:44 +00:00
Outdated
Review
Copy Link

Check for videoCalls[callId].initiatorConsumerVideo is redundant.

Check for `videoCalls[callId].initiatorConsumerVideo` is redundant.
} else {
console.log('🟥');
console.log(`[consumer-resume] isInitiator false`);
await videoCalls[callId]?.receiverConsumerVideo?.resume();
await videoCalls[callId]?.receiverConsumerAudio?.resume();
receiverConsumerVideo && videoCalls[callId].receiverConsumerVideo?.resume();
receiverConsumerAudio && videoCalls[callId].receiverConsumerAudio?.resume();
}
} catch (error) {
console.log(`ERROR | consumer-resume | callId ${socketDetails[socket.id]} | ${error.message}`);