Safemobile/mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

LH-276: Add close-producer event handler; Update client #30

Merged
sergiu merged 9 commits from LH-276-close-producer into develop 2023-02-23 09:46:42 +00:00
Conversation 0 Commits 9 Files Changed 4 +137 -195
sergiu commented 2023-02-21 00:43:44 +00:00
Member
Copy Link
No description provided.
sergiu added 1 commit 2023-02-21 00:43:45 +00:00
sergiu requested review from cristi 2023-02-21 00:43:50 +00:00
cristi requested changes 2023-02-22 11:00:12 +00:00
app.js Outdated
@ -446,0 +415,4 @@
!!videoCalls[callId].router.canConsume({
producerId: videoCalls[callId].initiatorAudioProducer.id,
rtpCapabilities,
});
cristi commented 2023-02-22 10:54:00 +00:00
Owner
Copy Link
  • we should not use the same variables for both receiver and initiator, we can improve the naming with something like canConsumeAudioReceiver and canConsumeAudioInitiator
  • the assignments for canConsumeAudio and canConsumeVideo are very similar and very hard to distinguish if something is wrong, extract it in a function and use it in all 4 places
    • something like: initCanConsume(producer, callId, rtpCapabilities)
  • not sure if !! is necessary in all places
* we should not use the same variables for both receiver and initiator, we can improve the naming with something like `canConsumeAudioReceiver` and `canConsumeAudioInitiator` * the assignments for `canConsumeAudio` and `canConsumeVideo` are very similar and very hard to distinguish if something is wrong, extract it in a function and use it in all 4 places * something like: `initCanConsume(producer, callId, rtpCapabilities)` * not sure if `!!` is necessary in all places
app.js Outdated
@ -477,0 +461,4 @@
videoCalls[callId].receiverConsumerVideo && videoCalls[callId].receiverConsumerVideo.resume();
videoCalls[callId].receiverConsumerAudio && videoCalls[callId].receiverConsumerAudio.resume();
}
} catch (error) {
cristi commented 2023-02-22 10:59:39 +00:00
Owner
Copy Link
  • optional chaining
  • based on isInitiatorValue we can assign consumerVideo and consumerAudio and call resume on them
consumerVideo = isInitiatorValue?  videoCalls[callId].initiatorConsumerVideo : videoCalls[callId].receiverConsumerVideo
consumerAudio = ...
consumerVideo?.resume();
* optional chaining * based on `isInitiatorValue` we can assign `consumerVideo` and `consumerAudio` and call resume on them ```javascript consumerVideo = isInitiatorValue? videoCalls[callId].initiatorConsumerVideo : videoCalls[callId].receiverConsumerVideo consumerAudio = ... consumerVideo?.resume(); ```
sergiu marked this conversation as resolved
sergiu added 1 commit 2023-02-22 16:22:33 +00:00
sergiu added 1 commit 2023-02-22 16:31:08 +00:00
sergiu added 1 commit 2023-02-22 16:33:19 +00:00
sergiu added 1 commit 2023-02-22 16:37:38 +00:00
sergiu added 1 commit 2023-02-22 16:41:36 +00:00
sergiu added 1 commit 2023-02-22 16:46:49 +00:00
sergiu added 1 commit 2023-02-22 16:51:15 +00:00
sergiu added 1 commit 2023-02-22 16:58:36 +00:00
sergiu requested review from cristi 2023-02-22 17:04:54 +00:00
cristi approved these changes 2023-02-22 17:50:43 +00:00
cristi left a comment
Owner
Copy Link

Let's test it well before merging.

Let's test it well before merging.
sergiu merged commit df7f1987f6 into develop 2023-02-23 09:46:42 +00:00
sergiu deleted branch LH-276-close-producer 2023-02-23 09:46:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
cristi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Safemobile/mediasoup#30
No description provided.
Delete Branch "LH-276-close-producer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?