Safemobile
/
mediasoup
21
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

comsume-undefined #22

Merged
sergiu merged 9 commits from comsume-undefined into develop 2023-01-12 13:31:47 +00:00
Conversation 0 Commits 9 Files Changed 1 +7 -9
sergiu commented 2023-01-12 10:48:40 +00:00
Member
Copy Link
No description provided.
sergiu added 6 commits 2023-01-12 10:48:40 +00:00
sergiu requested review from cristi 2023-01-12 10:48:43 +00:00
cristi requested changes 2023-01-12 10:50:49 +00:00
app.js Outdated
@ -453,2 +451,2 @@
await videoCalls[callId].initiatorConsumerVideo.resume();
await videoCalls[callId].initiatorConsumerAudio.resume();
videoCalls[callId].initiatorConsumerVideo && videoCalls[callId].initiatorConsumerVideo?.resume();
videoCalls[callId].initiatorConsumerAudio && videoCalls[callId].initiatorConsumerAudio?.resume();
cristi commented 2023-01-12 10:50:44 +00:00
Owner
Copy Link

Check for videoCalls[callId].initiatorConsumerVideo is redundant.

Check for `videoCalls[callId].initiatorConsumerVideo` is redundant.
sergiu added 1 commit 2023-01-12 10:50:53 +00:00
sergiu added 1 commit 2023-01-12 12:33:09 +00:00
cristi approved these changes 2023-01-12 12:33:53 +00:00
sergiu added 1 commit 2023-01-12 13:09:37 +00:00
cristi approved these changes 2023-01-12 13:13:05 +00:00
sergiu merged commit 6fd6ca9755 into develop 2023-01-12 13:31:47 +00:00
sergiu deleted branch comsume-undefined 2023-01-12 13:31:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
cristi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Safemobile/mediasoup#22
No description provided.
Delete Branch "comsume-undefined"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?