app.js

@@ -124,6 +124,16 @@ const closeCall = (callId) => {
   }
 }
 
+const getRtpCapabilities = (callId, callback) => {
+  try {
+    console.log('[getRtpCapabilities] callId', callId);
+    const rtpCapabilities = videoCalls[callId].router.rtpCapabilities;
+    callback({ rtpCapabilities });
+  } catch (error) {
+    console.log(`ERROR | getRtpCapabilities | callId ${callId} | ${error.message}`);
+  }
+}
+
 /*
   - Handlers for WS events
   - These are created only when we have a connection with a peer
@@ -150,9 +160,7 @@ peers.on('connection', async socket => {
     - If the room already exists, it will not create it, but will only return rtpCapabilities
   */
   socket.on('createRoom', async ({ callId }, callback) => {
-    let callbackResponse = null;
     try {
-      // We can continue with the room creation process only if we have a callId
       if (callId) {
         console.log(`[createRoom] socket.id ${socket.id} callId ${callId}`);
         if (!videoCalls[callId]) {
@@ -161,19 +169,12 @@ peers.on('connection', async socket => {
           console.log(`[createRoom] Router ID: ${videoCalls[callId].router.id}`);
         }
         socketDetails[socket.id] = callId;
-
-        // rtpCapabilities is set for callback
-        console.log('[getRtpCapabilities] callId', callId);
-        callbackResponse = { 
-          rtpCapabilities :videoCalls[callId].router.rtpCapabilities
-        };
+        getRtpCapabilities(callId, callback);
       } else {
         console.log(`[createRoom] missing callId ${callId}`);
       }
     } catch (error) {
       console.log(`ERROR | createRoom | callId ${callId} | ${error.message}`);
-    } finally {
-      callback(callbackResponse);
     }
   });
 
@@ -194,19 +195,16 @@ peers.on('connection', async socket => {
           videoCalls[callId].producerTransport = await createWebRtcTransportLayer(callId, callback);
         } else {
           console.log(`producerTransport has already been defined | callId ${callId}`);
-          callback(null);
         }
       } else if (!sender) {
         if (!videoCalls[callId].consumerTransport) {
           videoCalls[callId].consumerTransport = await createWebRtcTransportLayer(callId, callback);
         } else {
           console.log(`consumerTransport has already been defined | callId ${callId}`);
-          callback(null);
         }
       }
     } catch (error) {
       console.log(`ERROR | createWebRtcTransport | callId ${socketDetails[socket.id]} | sender ${sender} | ${error.message}`);
-      callback(error);
     }
   });
 
@@ -250,9 +248,9 @@ peers.on('connection', async socket => {
       });
 
       // Send back to the client the Producer's id
-      callback && callback({
-        id: videoCalls[callId].producer.id
-      });
+      // callback({
+      //   id: videoCalls[callId].producer.id
+      // });
     } catch (error) {
       console.log(`ERROR | transport-produce | callId ${socketDetails[socket.id]} | ${error.message}`);
     }
@@ -323,7 +321,6 @@ peers.on('connection', async socket => {
         callback({ params });
       } else {
         console.log(`[canConsume] Can't consume | callId ${callId}`);
-        callback(null);
       }
     } catch (error) {
       console.log(`ERROR | consume | callId ${socketDetails[socket.id]} | ${error.message}`)